[Bug 775541] leaks: Implement ref/unref tracing in the leaks tracer

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=775541

Guillaume Desmottes <gdesmott at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #341282|none                        |needs-work
             status|                            |

--- Comment #11 from Guillaume Desmottes <gdesmott at gnome.org> ---
Review of attachment 341282:
 --> (https://bugzilla.gnome.org/review?bug=775541&attachment=341282)

::: gst/gsttracerutils.h
@@ +600,3 @@
+ * @self: the tracer instance
+ * @ts: the current timestamp
+ * @object: the  object being unreffed

Double spaces here.

@@ +617,3 @@
+ * @self: the tracer instance
+ * @ts: the current timestamp
+typedef void (*GstTracerHookObjectUnreffed) (GObject *self, GstClockTime ts,

here too.

::: plugins/tracers/gstleaks.c
@@ -57,0 +58,10 @@
+typedef struct
+{
+  gboolean reffed;
... 7 more ...

Call it 'creation_trace' to avoid confusion with ObjectRefingInfo->trace? Or at
least add a comment.

@@ -426,2 +535,3 @@
     Leak *leak = l->data;

+    for (ref = leak->infos->refing_infos; ref; ref = ref->next) {

Shouldn't you reverse the reffing_infos list first so they are listed in the
right order?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.