[Bug 775541] leaks: Implement ref/unref tracing in the leaks tracer

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=775541

--- Comment #14 from Thibault Saunier <tsaunier at gnome.org> ---
(In reply to Guillaume Desmottes from comment #11)
> Review of attachment 341282 [details] [review]:
> 
> ::: gst/gsttracerutils.h
> @@ +600,3 @@
> + * @self: the tracer instance
> + * @ts: the current timestamp
> + * @object: the  object being unreffed
> 
> Double spaces here.

FIXED

> @@ +617,3 @@
> + * @self: the tracer instance
> + * @ts: the current timestamp
> +typedef void (*GstTracerHookObjectUnreffed) (GObject *self, GstClockTime ts,
> 
> here too.

FIXED

> ::: plugins/tracers/gstleaks.c
> @@ -57,0 +58,10 @@
> +typedef struct
> +{
> +  gboolean reffed;
> ... 7 more ...
> 
> Call it 'creation_trace' to avoid confusion with ObjectRefingInfo->trace? Or
> at least add a comment.

DONE, you are right it was confusing.

> @@ -426,2 +535,3 @@
>      Leak *leak = l->data;
>  
> +    for (ref = leak->infos->refing_infos; ref; ref = ref->next) {
> 
> Shouldn't you reverse the reffing_infos list first so they are listed in the
> right order?


DONE.

Pushing now.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.