[Bug 776334] Memory leak fixed in usage of gst_element_get_request() API

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=776334

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #342296|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 342296:
 --> (https://bugzilla.gnome.org/review?bug=776334&attachment=342296)

::: ext/resindvd/resindvdbin.c
@@ +719,3 @@

+  if (gst_pad_link (pad, mq_sink) != GST_PAD_LINK_OK) {
+    gst_object_unref (mq_sink);

This looks wrong. The pad is stored above in the list, and that's probably what
should own the reference. And later when the list is emptied (and the pads are
released), the unref should happen

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.