[Bug 776303] vaapisink: race condition during caps negotiation with multiple src elements

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=776303

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #342298|none                        |needs-work
             status|                            |

--- Comment #5 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 342298:
 --> (https://bugzilla.gnome.org/review?bug=776303&attachment=342298)

::: gst/vaapi/gstvaapisink.c
@@ +1221,1 @@
 }

I would change the code style to follow what is used in the project:

if (!gst_vaapi_sink_ensure_display (sink))
  return FALSE;

/* explain here why we are doing this */
if (!gst_vaapi_plugin_base_allowed_raw_caps (GST...))
  return FALSE;

return TRUE;

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.