[Bug 776352] dashdemux: Drain remaining buffer in adapter

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Dec 21 14:48:09 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=776352

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #342320|none                        |reviewed
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 342320:
 --> (https://bugzilla.gnome.org/review?bug=776352&attachment=342320)

::: ext/dash/gstdashdemux.c
@@ +2539,3 @@
+
+    /* Drain adapter */
+    gst_adapter_push (dash_stream->isobmff_adapter, buffer);

Why are you pushing the buffer in here? Isn't the buffer actually from the
beginning of the adapter, not the end, and now you add it to the end?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list