[Bug 776376] Fix memory leaks in usage of gst_element_get_clock API

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=776376

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #342370|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 342370:
 --> (https://bugzilla.gnome.org/review?bug=776376&attachment=342370)

::: sys/winscreencap/gstdx9screencapsrc.c
@@ +518,3 @@
       GST_OBJECT_UNLOCK (src);
+      if (clock != NULL)
+        gst_object_unref (clock);

The code using the clock here seems generally broken. The "if (frame_number !=
-1 && frame_number == src->frame_number)" assumes that clock != NULL although
the code above it handles the other case too.

Please fix that while you're at it.


Apart from that all these changes look ok

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.