[Bug 776334] Memory leak fixed in usage of gst_element_get_request_pad() API

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Dec 22 11:18:54 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=776334

--- Comment #6 from Garima <garima.g at samsung.com> ---
Do you mean that following fix for resindvd was correct in earlier patch:

--- a/ext/resindvd/resindvdbin.c
+++ b/ext/resindvd/resindvdbin.c
@@ -717,8 +717,10 @@ connect_thru_mq (RsnDvdBin * dvdbin, GstPad * pad)
     return FALSE;
   dvdbin->mq_req_pads = g_list_prepend (dvdbin->mq_req_pads, mq_sink);

-  if (gst_pad_link (pad, mq_sink) != GST_PAD_LINK_OK)
+  if (gst_pad_link (pad, mq_sink) != GST_PAD_LINK_OK) {
+    gst_object_unref (mq_sink);
     return FALSE;
+  }

   sinkname = gst_pad_get_name (mq_sink);
   tmp = sinkname + 5;
@@ -727,6 +729,7 @@ connect_thru_mq (RsnDvdBin * dvdbin, GstPad * pad)
   mq_src = gst_element_get_static_pad (dvdbin->pieces[DVD_ELEM_MQUEUE],
       srcname);

+  gst_object_unref (mq_sink);
   g_free (sinkname);
   g_free (srcname);

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list