[Bug 770355] id3v2: Fix parsing extended header and string lists in UTF-16

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=770355

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.11.1

--- Comment #11 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Thanks, pushed this now (without the have_bom code I mentioned above):

commit 4a8640b4c93f3c23163de039bf847a5bd23fe878
Author: Tim-Philipp Müller <tim at centricular.com>
Date:   Sat Dec 24 10:15:24 2016 +0000

    tests: tag: add unit test for ID3v2 UTF-16 string list parsing

    https://bugzilla.gnome.org/show_bug.cgi?id=770355

commit fae81e57c77e295235e739dcb944fd2dd9a27eab
Author: Tim-Philipp Müller <tim at centricular.com>
Date:   Sat Dec 24 14:32:34 2016 +0000

    tests: tag: add test for ID3v2 extended header parsing

    https://bugzilla.gnome.org/show_bug.cgi?id=770355

commit cd101ce8f02b2aaee40dcdfb63a9b8794b897006
Author: Thomas Bluemel <tbluemel at control4.com>
Date:   Wed Aug 24 11:39:39 2016 -0600

    id3v2: fix splitting strings in ISO-8859-1 and UTF-16 formats

    When parsing NUL-terminated strings, do not include the terminating
    NUL byte(s).  Depending on the encoding used, either g_utf8_validate()
    failed due to this, or worse the call to g_utf16_to_utf8() would
    return 0 items read on an empty string, causing it to fail parsing
    certain frames.

    https://bugzilla.gnome.org/show_bug.cgi?id=770355

commit da6070054f471216adac2c5879031fcebfa592d2
Author: Thomas Bluemel <tbluemel at control4.com>
Date:   Wed Aug 24 10:33:14 2016 -0600

    id3v2: fix handling of tags with extended headers

    The extended header size value does not include itself.

    https://bugzilla.gnome.org/show_bug.cgi?id=770355


Please re-open if you believe that was needed, thanks!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.