[Bug 776447] videotimecode: New GstVideoTimeCodeDiff type, ability to add to a GstVideoTimeCode

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=776447

Jan Schmidt <thaytan at noraisin.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #342423|none                        |needs-work
             status|                            |

--- Comment #4 from Jan Schmidt <thaytan at noraisin.net> ---
Review of attachment 342423:
 --> (https://bugzilla.gnome.org/review?bug=776447&attachment=342423)

One typo, otherwise looks fine to me.

::: gst-libs/gst/video/gstvideotimecode.c
@@ +713,3 @@
+ */
+GstVideoTimeCodeInterval *
+gst_video_time_code_interval_new_from_string (const gchar * tc_str)

tc_str -> tc_diff_str

@@ +719,3 @@
+  gchar **parts;
+
+  parts = g_strsplit (tc_diff_str, ":", 4);

The parameter name in the function definition is wrong, so this line doesn't
compile.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.