[Bug 766991] multifilesink: leaks memory when max-files property ==

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Sat Dec 31 09:59:11 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=766991

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.11.1

--- Comment #3 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
commit eb5ee5b7a366c6f8f216255d579aa669b908eafd
Author: Tim-Philipp Müller <tim at centricular.com>
Date:   Sat Dec 31 09:52:25 2016 +0000

    multifilesink: refactor max_files handling a bit

    Use GQueue instead of a GSList so we don't have to traverse
    the whole list to append something every time. And it also
    keeps track of the number of items in it for us.

    Add a function to add filenames to the list of old files and
    use it in more places, so that memory doesn't build up in
    other modes either if no max_files limit is specified.

    https://bugzilla.gnome.org/show_bug.cgi?id=766991

commit a10c1cc060648fd3ac6ab47d241f54eafc756248
Author: Ursula Maplehurst <ursula at kangatronix.co.uk>
Date:   Sun May 29 17:21:47 2016 +0100

    multifilesink: don't leak memory when no max-files limit is set

    Technically we weren't leaking the memory, just storing it internally
    and never using it until the element is freed. But we'd still use more
    and more memory over time, so this is not good over longer periods
    of time. Only keep track of files if there's actually a limit set,
    so that we will prune the list from time to time.

    https://bugzilla.gnome.org/show_bug.cgi?id=766991

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list