[Bug 761399] rtspmedia: Missing lock in default_unsuspend, preroll_failed path

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=761399

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.i.m at zen.co.uk
 Attachment #320178|none                        |reviewed
             status|                            |

--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 320178
  --> https://bugzilla.gnome.org/attachment.cgi?id=320178
rtsp-media: fix state_lock not locked again when preroll fails.

Thanks for the patch, looks good.

Could I persuade you to rewrite it as follows: add a gboolean preroll_ok so
that the flow is:

  unlock()
  preroll_ok = wait_preroll()
  lock()

  if (!preroll_ok)
    goto fail;

? (I know we usually do unlocks and such also in the error code paths, but here
it's easy to keep the locking pair in one place so it seems preferable to me to
do that instead)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.