[Bug 759192] start gstreamer-vaapi "upstream-ization"

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Feb 2 07:29:54 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=759192

--- Comment #25 from sreerenj <bsreerenj at gmail.com> ---
(In reply to Víctor Manuel Jáquez Leal from comment #23)
> (In reply to Tim-Philipp Müller from comment #20)
> > One more thing I noticed: ./autogen.sh now installs the local pre-commit
> > hook to check for GStreamer-style indentation with GNU indent.
> > 
> > The entire code base has indentation that's inconsistent with the GStreamer
> > indentation though, try: gst-indent gst-libs/gst/vaapi/*.c gst/vaapi/*.c
> > 
> > How do you want to handle this?
> > 
> > Options:
> > 
> > a) one commit to reindent everything
> > 
> > b) git filter-branch which re-indents the entire history (this way
> > everything will be tidy from the start and history won't be 'disturbed' by a
> > global reindentation commit, downside is the history is then not a neat
> > continuation on top of the old github repository [it is of course, but it
> > won't look like that to git])
> > 
> > c) carry on with custom indentation (my least favourite option)
> 
> I'd change all by once in gst/vaapi/*.c since there were only a couple
> errors in the indentation.
> 
> In the case of gst-libs/vaapi/*.c the changes would be massive. I don't know.
> 
> Sree, what do you think?

Just do a massive gst-indent in gst-libs/gst/vaapi,, only problem is that we
have to rewrite the pending patches in bugzilla for merging ;)

BTW, i am still pushing few vp9decode patches in github,,,would be great if you
can rebase those before indenting...

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list