[Bug 761458] New: adaptivedemux: Unused GstSegment variable in download loop

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=761458

            Bug ID: 761458
           Summary: adaptivedemux: Unused GstSegment variable in download
                    loop
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: david.waring at rd.bbc.co.uk
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Created attachment 320265
  --> https://bugzilla.gnome.org/attachment.cgi?id=320265&action=edit
Option 1: Use the local variable to create the new segment message.

During processing in gst_adaptive_demux_stream_download_loop, if the
stream->restart_download boolean is set, a local GstSegment variable, segment,
is created and updated with a new offset, but is then never actually used.
Instead stream->segment is used to send a new segment event.

This looks wrong, so I suspect either the local variable shouldn't be there and
stream->segment should be used instead or the local variable should be there
and should be the one used in the new segment event.

However I'm unsure as to exactly what this ought to look like, so here are 3
patches which are my guesses at what the code should look like.

1. Use the local variable to create the new segment message.
2. Remove the local segment variable and just use stream->segment instead.
3. Like 2 but also don't reinitialise stream->segment from demux->segment.

Could someone who understands what the code should be doing have a look at this
bit of the code?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.