[Bug 761014] File can't be played with hardware acceleration in Android gstreamer tutorial 5

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=761014

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #320402|none                        |reviewed
             status|                            |

--- Comment #65 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 320402:
 --> (https://bugzilla.gnome.org/review?bug=761014&attachment=320402)

::: sys/androidmedia/gstamcvideodec.c
@@ +421,3 @@
   gst_video_decoder_set_needs_format (GST_VIDEO_DECODER (self), TRUE);
+  gst_video_decoder_set_use_default_pad_acceptcaps (GST_VIDEO_DECODER (self),
+      TRUE);

The default one will always do a CAPS query downstream. The non-default one
will first check against the template, and only do a caps query downstream if
the caps are compatible with the template.

It might make sense to add a accept_caps vfunc to videodecoder, which will then
only check against the caps supported by this very element... without doing any
downstream caps queries at all.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.