[Bug 761586] systemclock: regression causing audiomixer to stall

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=761586

--- Comment #5 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 320511
  --> https://bugzilla.gnome.org/attachment.cgi?id=320511
systemclock: handle unschedule of late entries

Nice work tracking that down.

Mostly commenting on the code style of the refactoring, not the fix itself.

I find the way you have factored out
gst_system_clock_check_and_cleanup_unscheduled() a bit confusing, because the
'check' part (status argument and boolean return value) is only used in one
case, in the other two cases you ignore the return value and check status
outside of the function.

I think in the first chunk you should keep the status checking there and just
turn the function into a cleanup function without passing status or returning a
return value, unless I missed something.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.