[Bug 761609] New: qmlglsink: Clear buffer in transition to Null state instead of Ready state in gstqtsink.cc

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=761609

            Bug ID: 761609
           Summary: qmlglsink: Clear buffer in transition to Null state
                    instead of Ready state in gstqtsink.cc
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: gdevel at clixxun.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

I noticed that if my pipeline gets stopped, the glsinkbin displays some random
data from graphicd memory instead of the last image. To prevent this I changed
the behaviour in the way that the current buffer is set to NULL in transition
from READY to NULL instead of PAUSED to READY.
At least that fixes the visual aspect. But I am not sure if that has any side
effects I didnt notice yet.

Below the diff output for gstqtsink.cc:
---------------------------

index b6a6fa5..5471369 100644
--- a/ext/qt/gstqtsink.cc
+++ b/ext/qt/gstqtsink.cc
@@ -354,9 +354,9 @@ gst_qt_sink_change_state (GstElement * element,
GstStateChange transition)
     case GST_STATE_CHANGE_PLAYING_TO_PAUSED:
       break;
     case GST_STATE_CHANGE_PAUSED_TO_READY:
-      qt_item_set_buffer (qt_sink->widget, NULL);
       break;
     case GST_STATE_CHANGE_READY_TO_NULL:
+        qt_item_set_buffer (qt_sink->widget, NULL);
       break;
     default:
       break;
diff --git a/ext/qt/qtitem.cc b/ext/qt/qtitem.cc

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.