[Bug 760930] adaptivedemux: stream can pause for a long time when server errors encountered

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=760930

Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #320505|none                        |reviewed
             status|                            |

--- Comment #7 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Review of attachment 320505:
 --> (https://bugzilla.gnome.org/review?bug=760930&attachment=320505)

::: ext/hls/gsthlsdemux.c
@@ +414,3 @@
+}
+
+static GstFlowReturn

Please make sure this doesn't break the unit tests that do snap-seeking.

::: gst-libs/gst/adaptivedemux/gstadaptivedemux.c
@@ +2604,3 @@
+
+            gst_adaptive_demux_get_live_seek_range (demux, &range_start,
+                &range_end);

smoothstreaming doesn't implement this. We need to skip this if it isn't
implemented or just have some sane default that we could try, perhaps the last
fragment timestamp in the current manifest version?

@@ +2605,3 @@
+            gst_adaptive_demux_get_live_seek_range (demux, &range_start,
+                &range_end);
+            stream_time = range_end - stream->segment.base;

Do we need to subtract base here? AFAIK the ranges are already in the correct
values.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.