[Bug 752760] qtdemux: Fix wrong setting of max_buffer_size for LPCM files.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752760

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nicolas.dufresne at collabora.
                   |                            |co.uk

--- Comment #7 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Apparently the author of this 4096 hardcode new this was not working well:

commit 5bd2864101d837642fe37244aab58ab29dbca37a
Author: David Schleef <ds at schleef.org>
Date:   Tue Mar 5 17:00:17 2013 -0800

    qtdemux: split large raw audio samples

    In order to deal with a file that has samples that are 24 seconds
    long.  Seeking still doesn't work with such files.

Though your patch is a little strange, it feels like it hides another bug.
bytes_per_frame sound like the frame size which iirc is defined as:

  framesize = num_channels * rate * sample_size

If your framesize is correct, splitting your audio buffers in any multiple of
that value should be fine (so 4096 * framesize, should be a valid value, it's
complitly arbitrary, but valid).

But digging up the code I found this (line 9610):

  stream->bytes_per_frame = stream->n_channels * stream->bytes_per_sample;

Isn't this where the bug is in fact ? (also, don't put indent changes along
with patches).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.