[Bug 758852] tsdemux segfault

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=758852

Matthew Waters (ystreet00) <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #320808|none                        |needs-work
             status|                            |

--- Comment #6 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
Review of attachment 320808:
 --> (https://bugzilla.gnome.org/review?bug=758852&attachment=320808)

This doesn't seem right...

::: gst-libs/gst/gl/gstglbasememory.c
@@ +200,3 @@
       "pointer of size %" G_GSIZE_FORMAT, gl_mem, gl_mem->alloc_size);
+  maxsize = gl_mem->alloc_size + mem->align - 1;
+  gl_mem->alloc_data = g_try_malloc (maxsize);

alloc_size is already maxsize + align.  The fact that you're adding another +
align is not correct.

Also, align - 1 doesn't make any sense either.

It would be useful to see some numbers as to why this is needed

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.