[Bug 761588] opusdec: no mono/stereo channel conversion

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=761588

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #320728|none                        |needs-work
             status|                            |

--- Comment #6 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 320728:
 --> (https://bugzilla.gnome.org/review?bug=761588&attachment=320728)

::: ext/opus/gstopusdec.c
@@ +239,2 @@
     caps = gst_caps_truncate (caps);
     caps = gst_caps_make_writable (caps);

If I see this correctly, we would now also allow outputting stereo for 5.1
input and the other way around?

@@ +399,3 @@
+        && dec->n_stereo_streams == 0) {
+      // if we are automatically decoding 2 channels, but only have
+      // a single encoded one, direct both channels to it

No && comments please :)

@@ +841,3 @@
+      GstStructure *s = gst_caps_get_structure (filter, n);
+      if (gst_structure_get_int (s, "channels", &channels)) {
+        if (channels == 1 || channels == 2) {

Even without a filter something can be done here. In the resulting caps we
should be able to set channels to [1,2] too even if downstream only supports
one of the two (as we can convert in the decoder)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.