[Bug 761702] rtsp-thread-pool: explain why GSource is a part of GstRTSPThreadImpl

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=761702

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #320612|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 320612:
 --> (https://bugzilla.gnome.org/review?bug=761702&attachment=320612)

::: gst/rtsp-server/rtsp-thread-pool.c
@@ +180,3 @@
     g_source_set_callback (impl->source, (GSourceFunc) do_quit,
         thread, (GDestroyNotify) gst_rtsp_thread_unref);
+    if (G_UNLIKELY (g_source_attach (impl->source, thread->context) <= 0)) {

>From the code of g_source_attach() it's actually impossible to get 0 here (and
< 0 anyway as it's unsigned).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.