[Bug 761913] ghostpad: Do nothing in _internal_activate_push_default

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Feb 17 10:32:44 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=761913

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
commit 87c2254b1d1e5d3478150545e97915fc8dab4a5a
Author: Havard Graff <havard.graff at gmail.com>
Date:   Wed Feb 17 11:02:34 2016 +0100

    ghostpad: add some tests for activation

    https://bugzilla.gnome.org/show_bug.cgi?id=761913

commit ab55ad7eaad4fa2c0b16c789350e882cf70a27ed
Author: Stian Selnes <stian at pexip.com>
Date:   Wed Jan 27 13:20:23 2016 +0100

    ghostpad: Do nothing in _internal_activate_push_default

    When calling gst_pad_activate_mode() on a ghostpad
    gst_ghost_pad_activate_push_default() will be called. This will call
    gst_pad_activate_mode() on the proxypad (which is internal of the
    ghostpad), calling gst_ghost_pad_internal_activate_push_default(), which
    again will call gst_pad_activate_mode() on the original ghostpad.

    By simply returning TRUE in
    gst_ghost_pad_internal_activate_push_default() the redundant call to
    gst_pad_activate_mode() (for the same pad) is avoided.

    https://bugzilla.gnome.org/show_bug.cgi?id=761913

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list