[Bug 761769] qtdemux: incorrectly sets caps of CENC encrypted streams

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Feb 17 15:06:38 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=761769

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Pushed with a minor change to use gst_structure_has_name(). Thanks!


commit 97f6f7c71348dc49b32183f83c1000379ead2b77
Author: Alex Ashley <bugzilla at ashley-family.net>
Date:   Tue Feb 9 13:17:00 2016 +0000

    qtdemux: only transform protected caps once

    Commit 7873bede3134b15e5066e8d14e54d1f5054d2063
    (https://bugzilla.gnome.org/show_bug.cgi?id=760774) changed the
    behaviour of qtdemux to call gst_qtdemux_configure_stream() for
    every new moof.

    When playing a protected stream, gst_qtdemux_configure_stream()
    calls gst_qtdemux_configure_protected_caps(). The
    gst_qtdemux_configure_protected_caps() function takes the original
    media format, puts this in a field called "original-media-type"
    and then changes the caps to "application/x-cenc".

    The gst_qtdemux_configure_protected_caps() did not handle the case
    of being called multiple times, causing it to incorrectly set the
    caps. The second call was causing the caps to be set to:

        application/x-cenc, original-media-type"application/x-cenc"

    This commit makes gst_qtdemux_configure_protected_caps() check that
    the caps have already been transformed, so that it only gets
    changed once.

        https://bugzilla.gnome.org/show_bug.cgi?id=761769

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list