[Bug 754224] audioencoder: timestamp headers same as first buffer and use duration 0

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=754224

--- Comment #8 from Håvard Graff (hgr) <havard.graff at gmail.com> ---
If the headers will contain information that is globally applicable to any part
of the stream at any time then I agree that the timestamping information might
not be important. However if, say, the headers will contain information that
might potentially change during the lifetime of the stream (change of bitrate
or clock-rate, coding-type etc.) then it makes complete sense to place them in
relation to the stream, so that they can be sorted and the stream still makes
sense. Now, being a base-class, this implementation might cater for a lot of
codecs that only needs (and supports) one single configuration, but it might
*also* need to cater for a codec where the header-info might change runtime,
and hence the base-class *should* (IMHO) timestamp its headers.

As for the duration, I have no strong opinions, so I am happy to keep this -1
for headers, since duration is arguably something that only applies to the
original (decoded) data but can be kept intact by the encoded buffers as well.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.