[Bug 762326] gstrtpjitterbuffer GST_QUERY_POSITION reports position and not stream_time

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=762326

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #321671|none                        |reviewed
             status|                            |

--- Comment #8 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 321671:
 --> (https://bugzilla.gnome.org/review?bug=762326&attachment=321671)

::: gst/rtpmanager/gstrtpbin.c
@@ +1464,3 @@
+                                             (G_GINT64_CONSTANT (1) << 32));
+          /* convert from 1900 based time to 1970 based time */
+          ntpnstime -= 2208988800000000000LL;

Why do you do this conversion here? This seems to defeat the purpose a bit, you
are going to report "time since 1970" as stream time instead of "time since
1900", the latter actually being the NTP time.

@@ +1474,3 @@
+           * time values and get the equivalent NTP time.
+           */
+          segment->time = ntpnstime - local_running_time;

This is unsigned, but ntpnstime can be smaller than the local running time. Not
sure what to do about that.


It should also be relative, i.e. segment->time += ...

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.