[Bug 762349] matroskamux: generated files sometimes don't open on android

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=762349

--- Comment #6 from Matej Knopp <matej.knopp at gmail.com> ---
Two things: Tags that serialize to empty string are handled correctly. So we
don't need to skip such tags (it actually wouldn't seem right anyway). Thus the
patch should cover all tag related scenarios.

> So I think we should not add empty SIMPLE_TAGS, and not TAGS and TAG if they are not going to contain anything

That's what my patch does. If none of the SIMPLE_TAGs are be written, the outer
TAGS and TAG will not be written either. Otherwise the file won't load.

Serializing the tag twice may not be the most elegant solution, but needs to be
done for consistency. gst_matroska_mux_write_simple_tag skips tags that won't
serialize, so we need to know upfront if that's the case before writing TAGS
and TAG.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.