[Bug 762542] New: matroskademux: CRITICAL when seeking on matroska files without buffers

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=762542

            Bug ID: 762542
           Summary: matroskademux: CRITICAL when seeking on matroska files
                    without buffers
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: linus.svensson at axis.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Created attachment 321988
  --> https://bugzilla.gnome.org/attachment.cgi?id=321988&action=edit
Fix a memory leak

matroskademux will raise a CRITICAL when performing a seek and the matroskafile
lacks frames. If the seek arrives at the pad, it will silently return FALSE,
but if the seek is sent to the demuxer directly a CRITICIAL is seen:

CRITICAL **: gst_matroska_demux_search_pos: assertion 'current_state ==
GST_MATROSKA_READ_STATE_DATA' failed

This will be the case even if the application waits for async-done (the
pipeline will also be eos after that) and then sends a flushing seek.

Attached a patch that makes the _send_event() function do the same sanity check
as if the seek entered through a pad.

Also found a memory leak that I fixed.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.