[Bug 762543] New: xvimagesink: wrong pool selection when rendering multi-resolution videos

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=762543

            Bug ID: 762543
           Summary: xvimagesink: wrong pool selection when rendering
                    multi-resolution videos
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Linux
            Status: NEW
          Severity: major
          Priority: Normal
         Component: gst-plugins-base
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: bsreerenj at gmail.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

The xvimagesink seems to create a pool in set_caps() and which is always using
as sink's internal pool irrespective of whether we create new pool in
propose_allocation() or not.
This is wrong when handling multi-resolution video rendering. The sink will
only receive the cropped resolution in set_caps() which is not what we supposed
to use for configuring the pool.
The actual un-cropped resolution which is supposed to be used in pool
configuration will be receiving in propose_allocation(). So the GstVideoInfo to
map the incoming buffers should be also derive from the propose_allocation.
right?

Either we can do pool creation only in propose_allocation() like glimagesink or
have to replace the xvimagesink->poll with newly created pool in
propose_allocation, and reset the xvimagesink->info too.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.