[Bug 762529] v4l2src produces wrong colorimetry info for NV12

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=762529

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #321976|none                        |needs-work
             status|                            |

--- Comment #5 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 321976:
 --> (https://bugzilla.gnome.org/review?bug=762529&attachment=321976)

::: sys/v4l2/gstv4l2object.c
@@ +1888,3 @@
+    matrix = V4L2_MAP_YCBCR_ENC_DEFAULT (colorspace);
+  if (range == V4L2_QUANTIZATION_DEFAULT)
+    range = V4L2_MAP_QUANTIZATION_DEFAULT (is_rgb, colorspace, matrix);

This makes the following switch completely use-less. Please remove the uneeded
code. Though, keep the _RAW case, since we have in GStreamer an explicit value
for "unknown", while those macro would pick random value which would then cause
confusion and errors (the macro are wrong for COLORSPACE_RAW).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.