[Bug 762660] gstflacparse commit broke tag scanning in mopidy

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=762660

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.i.m at zen.co.uk

--- Comment #1 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Thanks for the report.

I'm not quite sure how or why this commit would change anything for your
application, or why your commit fixes it.

I see two things in that mopidy commit:

1) if pipeline.set_state(PAUSED) == ASYNC
     pipeline.set_state(PLAYING)

So are you not getting tags in PAUSED state then? I would expect tags to be
extracted and push to the sink before buffers, but maybe it only posts the tag
events as sink messages in playing state. But then the question is why did you
get tags before? On a side note, you might just as well always set the pipeline
to playing state directly here, it will always be either async or live.

2) on MSG_ASYNC_DONE:
     if message.src == pipeline and tags:
       return tags, ..

Not sure what the 'and tags' addition helps here exactly, again it sounds like
you're not getting tags before ASYNC_DONE any more, but before the change you
did? (On a side note, you don't need to check for message.src == pipeline for
the ASYNC_DONE message).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.