[Bug 761588] opusdec: no mono/stereo channel conversion

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=761588

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #322373|none                        |needs-work
             status|                            |

--- Comment #23 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 322373:
 --> (https://bugzilla.gnome.org/review?bug=761588&attachment=322373)

Why the change for opusenc btw? This shouldn't be needed and seems incorrect.
It's the decoder that can downsample/downmix, not the encoder

::: ext/opus/gstopusdec.c
@@ +250,3 @@
+      else
+        gst_structure_set (s, "rate", G_TYPE_INT, dec->sample_rate, NULL);
+      gst_structure_get_int (s, "rate", &rate);

We can always output 48kHz, but if the input gives a different sample rate we
would prefer that one while still supporting to output 48kHz. Is this
considered here or will this only allow 48kHz if no sample rate on input?

@@ +254,1 @@
+      if (dec->sample_rate > 0 && dec->sample_rate != rate) {

If dec->sample_rate == 0, you would above set 0 inside the caps. That doesn't
seem right

@@ +254,3 @@
+      if (dec->sample_rate > 0 && dec->sample_rate != rate) {
+        GST_WARNING_OBJECT (dec, "Don't like rate of %u, wanted %u", rate,
+            dec->sample_rate);

Not a warning really, just normal negotiation happening here

@@ +268,3 @@
+        if (dec->n_channels > 2 || channels > 2) {
+          GST_WARNING_OBJECT (dec, "Don't like channels of %u, wanted %u",
+              channels, dec->n_channels);

Same here

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.