[Bug 762702] gst_bus_add_watch will SEGV when process reaches fd limit

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=762702

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #322415|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 322415:
 --> (https://bugzilla.gnome.org/review?bug=762702&attachment=322415)

Thanks for the patch! Can you update it slightly?

::: gst/gstbus.c
@@ +895,3 @@
+  if (!source) {
+    GST_ERROR_OBJECT (bus,
+        "gst_bus_create_watch failed so gst_bus_add_watch_full_unlocked
failed");

This should probably be a g_critical(). It's not like much is going to work
from this point onwards :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.