[Bug 761588] opusdec: no mono/stereo channel conversion

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=761588

--- Comment #27 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> ---
(In reply to Sebastian Dröge (slomo) from comment #26)
> Review of attachment 322389 [details] [review]:
> ::: ext/opus/gstopusdec.c
> @@ +261,3 @@
> +          }
> +        }
> +      }
> 
> This might need an else case where we explicitly check for 48000 only and
> ignore the structure otherwise we might select below a channel setup that is
> not going to work

I do not understand.

> And also an else case here I guess? What is if n_channels==0? What would we
> do then later? Stereo? If so we should check for stereo here

This is checked below, and default values set if nothing could be matched. This
may end up failing, probably.

> All this loop might be possible to do easier with gst_caps_intersect() btw.
> You could create new caps with only rate (if ->sample_rate != 0 then {x,
> 48000} else 48000) and channels (if ->n_channels ...). And then just check
> the result of the intersection with that. Or am I missing something?

I think that'd work (intersect, then truncate, then fixate). The intersection
would have got rid of the 1/5 case you mentioned earlier.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.