[Bug 761588] opusdec: no mono/stereo channel conversion

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=761588

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #322451|none                        |needs-work
             status|                            |

--- Comment #30 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 322451:
 --> (https://bugzilla.gnome.org/review?bug=761588&attachment=322451)

::: ext/opus/gstopusdec.c
@@ +241,3 @@
+    if (dec->sample_rate == 0) {
+      if (dec->n_channels == 0) {
+        str = g_strdup ("audio/x-raw");

If channels==0, don't we only support mono/stereo then? Or what do we do?

@@ +246,3 @@
+      } else {
+        str = g_strdup_printf ("audio/x-raw, channels=[%u]", dec->n_channels);
+      }

If sample_rate == 0 we only support 48kHz

@@ +262,2 @@
     }
+    constraint = gst_caps_from_string (str);

Why string programming?

caps = gst_caps_new_empty_simple("audio/x-raw");
if (dec->sample_rate == 0) {
  ...
  gst_caps_set_simple(caps, "channels", GST_TYPE_INT_RANGE, 1, 2, NULL);
}

etc

@@ +272,1 @@
       return;

Why doesn't this function return a boolean and propagate failures upwards?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.