[Bug 762715] mpegtsmux: alignment property and timestamps for Live UDP streaming

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=762715

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #322455|none                        |reviewed
             status|                            |

--- Comment #4 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 322455:
 --> (https://bugzilla.gnome.org/review?bug=762715&attachment=322455)

::: /gst-plugins-bad/gst/mpegtsmux/mpegtsmux.c
@@ +1526,3 @@
+    buf = gst_adapter_take_buffer (mux->out_adapter, align);
+    GST_BUFFER_PTS (buf) = ts;  
+    gst_buffer_list_add (buffer_list, buf);

Can't you use gst_adapter_prev_pts_at_offset() ? Also, this is encoded data,
shouldn't you first look for a DTS and if none then pick the PTS ? Specially in
your example, you have a B-Frame enabled H264 stream, so PTS is not monotonic,
hence not suited for synchronization.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.