[Bug 761588] opusdec: no mono/stereo channel conversion

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=761588

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #322464|none                        |needs-work
             status|                            |

--- Comment #35 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 322464:
 --> (https://bugzilla.gnome.org/review?bug=761588&attachment=322464)

::: ext/opus/gstopusdec.c
@@ +256,2 @@
     }
+    if (dec->n_channels == 0) {

Shouldn't this case go away and become the <= 2 one?

@@ +392,3 @@

+  if (!gst_opus_dec_negotiate (dec, posn))
+    return GST_FLOW_ERROR;

GST_FLOW_NOT_NEGOTIATED

@@ +433,3 @@

+      if (!gst_opus_dec_negotiate (dec, NULL))
+        return GST_FLOW_ERROR;

GST_FLOW_NOT_NEGOTIATED

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.