[Bug 762793] taginject does not copy the tag list it sends, so changes by other elements are propagated later

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=762793

--- Comment #2 from Sjors Gielen <gnome-bugzilla at sjor.sg> ---
I have a test case (attached) that works with GStreamer Editing Services, but
did not succeed in extracting one that works with pure GStreamer. I was pretty
sure the bug occurs when a pipeline is PLAYING with taginject+rgvolume, then
set to READY and set to PLAYING, but this did not turn out to be enough to
trigger the bug.

Anyway, the creation of the GstTagList happens at gst_tag_inject_set_property,
the sending happens at gst_tag_inject_transform_ip (note that no copy is made),
and then the modification happens at the bottom of gst_rg_volume_tag_event, and
I could confirm that at the end of gst_tag_inject_transform_ip the tags were
indeed gone from the GstTagList.

(I think that rgvolume removes the tags so that in the bin "rgvolume ! rgvolume
! rgvolume" only the first rgvolume actually normalizes, and the other two
don't see any tags and fallback to a 1.0 gain. But, I haven't tested this.)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.