[Bug 762793] rgvolume: modifies upstream tags in place without making them writable first

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=762793

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.7.90

--- Comment #5 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Made a unit test, so confirmed rgvolume does this wrong:

commit a4d64b5caa3fac5223e58b6d791fbd6fbe44ff72
Author: Tim-Philipp Müller <tim at centricular.com>
Date:   Sun Feb 28 13:42:28 2016 +0000

    rgvolume: make tag list writable before modifying it

    Making the event itself writable is not enough, it won't make
    the actual taglist in the event writable as well. Instead, just
    make a copy of the taglist and then create a new tag event from
    that if required, replacing the old one. Before we would
    inadvertently modify taglists upstream elements might still
    be holding on to. Add unit test for this as well.

    https://bugzilla.gnome.org/show_bug.cgi?id=762793


commit f02e52ba3ff11cdd72607591b878f1f4fa4e8faf
Author: Tim-Philipp Müller <tim at centricular.com>
Date:   Sun Feb 28 13:59:48 2016 +0000

    taglist: add guard to check writability when removing tags from a taglist

    https://bugzilla.gnome.org/show_bug.cgi?id=762793

Please re-open if you still have problems after these commits, thanks!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.