[Bug 760502] waylandsink: Preconditon of display handle is wrong, waylandsink need to change form GST_ELEMENT_ERROR to GST_ELEMENT_WARNING in gst_wayland_sink_set_window_handle

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=760502

--- Comment #3 from Hyunil Park <hyunil46.park at samsung.com> ---
I tried test.
The result is that waylandsink is working with internal display handle.
I only get wl_surface from external window.
I don't set gst_wayland_sink_set_display_from_context() to get display

the patch is need to below line .. :)
sorry, and thank you.

  if (handle) {
    if (G_LIKELY (gst_wayland_sink_find_display (sink))) {
      /* we cannot use our own display with an external window handle */
      if (G_UNLIKELY (sink->display->own_display)) {
          GST_ELEMENT_WARNING (sink, RESOURCE, OPEN_READ_WRITE,
              ("Application did not provide a wayland display handle"),
              ("Now waylandsink use internal display handle "
                  "which is created ourselves. Consider providing a "
                  "display handle from your application with GstContext"));
    +      sink->window = gst_wl_window_new_in_surface (sink->display,
surface);
      } else {
        sink->window = gst_wl_window_new_in_surface (sink->display, surface);
      }
    } else {
      GST_ERROR_OBJECT (sink, "Failed to find display handle, "
          "ignoring window handle");
    }
  }

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.