[Bug 762843] gstinfo: Refactor code to remove memory leak and FIXME.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=762843

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #322619|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 322619:
 --> (https://bugzilla.gnome.org/review?bug=762843&attachment=322619)

This seems safe, but please add comments in the code and commit message *why*
this is safe to do. Why we could never try to access freed memory here or run
into pointers pointing to freed memory.

::: gst/gstinfo.c
@@ +498,3 @@
   G_VA_COPY (message.arguments, args);

+  handler = g_slist_copy (__log_functions);

This would mean that the list is copied every single time you do some debug
output, and then freed again. Doesn't seem ideal performance-wise :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.