[Bug 762859] New: appsrc: max-bytes is silently ignored for block=FALSE

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=762859

            Bug ID: 762859
           Summary: appsrc: max-bytes is silently ignored for block=FALSE
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: All
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-base
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: hfink at toolsonair.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

max-bytes is ignored when block=FALSE. A comment in appsrc.c (line 1659) says: 

/* no need to wait for free space, we just pump more data into the
 * queue hoping that the caller reacts to the enough-data signal and
 * stops pushing buffers. */

In a live pipeline, if downstream of appsrc is slow (e.g. overwhelmed encoder),
but buffers are pushed into the appsrc as they arrive, then appsrc will be
growing its queue infinitely, which is unexpected to the application that
simply pushes buffers (and doesn't care about the enough-data signal).

Couldn't we just drop buffers for block=FALSE when max-bytes is reached?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.