[Bug 762856] It is possible hit Buffer Overflow - Array Index Out of Bounds in fill_iq_matrix_8x8 for H264

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=762856

--- Comment #3 from Lim Siew Hoon <siew.hoon.lim at intel.com> ---
(In reply to sreerenj from comment #1)
> We never hit this code,   See the code before invoking fill_iq_matrix_8x8()
> 
> /* XXX: we can only support 4:2:0 or 4:2:2 since ScalingLists8x8[]
>      is not large enough to hold lists for 4:4:4 */
>   if (sps->chroma_format_idc == 3)
>     return GST_VAAPI_DECODER_STATUS_ERROR_UNSUPPORTED_CHROMA_FORMAT;
> 
> Parse is supposed to parse whatever possible, which can be up to 6 scaling
> lists for 8x8, but libva only support two.

Yes, you are right. The checking is done in ensure_quant_matrix function before
the fill_iq_matrix_8x8 function get call. I missed out that one. Thank you for
feedback. You may closed the issue now. Thank you.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.