[Bug 760003] gst_parse_launch: warn if we're still waiting to plug sub-pipelines after no-more-pads

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=760003

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #318169|none                        |reviewed
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 318169:
 --> (https://bugzilla.gnome.org/review?bug=760003&attachment=318169)

Makes sense to me, just some cosmetic comments

::: gst/parse/grammar.y
@@ +498,3 @@
+    ("failed delayed linking %s:%s to %s:%s",
+                   GST_STR_NULL (GST_ELEMENT_NAME (src)), GST_STR_NULL
(link->src_pad),
+                   GST_STR_NULL (GST_ELEMENT_NAME (link->sink)), GST_STR_NULL
(link->sink_pad)),

The user-facing error message should probably be something less detailed and
technical :)

@@ +768,3 @@
 *    (e.g. fakesrc ! sinkreferencename.padname)
 **************************************************************/
+chain:    openchain                  { $$=$1;

Why these whitespace changes?

@@ +812,3 @@
                         $$->src.pads = NULL;
                         $$->sink.pads = NULL;
+                        $$->caps = NULL;

and here and in various other places

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.