[Bug 760003] gst_parse_launch: warn if we're still waiting to plug sub-pipelines after no-more-pads

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Sun Jan 3 08:26:37 PST 2016


https://bugzilla.gnome.org/show_bug.cgi?id=760003

--- Comment #7 from Stefan Sauer (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> ---
Thanks for the better commit messaged. Applied.

Regarding the error code, instead of GstParseError it would need to ge
GstParseLaunchError and likewise GST_PARSE_LAUNCH_ERROR_DELAYED_LINKING =>
PARSE_LAUNCH, DELAYED_LINKING to not confuse this with parsing errors as such.
It's a bit longish but doable.

Regarding the message, I was thinking about it, but I am concerned with i18n.
The message would become quite modular; we'd build 'name-fragments' for each
side of the link, like:

if (pad_name) {
  src_name = g_strdup_sprintf (_("pad %s of %s element named %s"), ...);
} else
  src_name = g_strdup_sprintf (_("%s element named %s"), ...);
}

and then combine the fragments:

_("Linking %s to %s failed. Check that caps are compatible."), src_name,
sink_name);

If done right these name helpers could be added to gst_util and used elsewhere
too.

Ideally we do this step by step though.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list