[Bug 755971] queue2: may overflow unsigned integer arithmetic

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=755971

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #312726|none                        |needs-work
             status|                            |

--- Comment #14 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 312726:
 --> (https://bugzilla.gnome.org/review?bug=755971&attachment=312726)

::: plugins/elements/gstqueue2.c
@@ +837,3 @@
   }
+#define GET_PERCENT(format,alt_max) \
+        queue->max_level.format > 0 \

You need to add an extra parentheses around macros, around all use of the input
parameters. You'll have to store format into a variable as you expend it
multiple time, otherwise you may have side effects. In the end, I'd say just
change that into an inline function.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.