[Bug 760127] mpegtsmux: Reserve bits not set to to 1's

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Jan 5 11:26:59 PST 2016


https://bugzilla.gnome.org/show_bug.cgi?id=760127

Reynaldo H. Verdejo Pinochet <reynaldo at opendot.cl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #318266|none                        |needs-work
             status|                            |

--- Comment #4 from Reynaldo H. Verdejo Pinochet <reynaldo at opendot.cl> ---
Review of attachment 318266:
 --> (https://bugzilla.gnome.org/review?bug=760127&attachment=318266)

Thanks for the new patch. I don't have access to the standard
so can't really comment on its correctness but in the mean time,
please correct the following:

::: gst/mpegtsmux/tsmux/tsmux.c
@@ +936,3 @@
 fail:
+  if (packet)
+    g_free (packet);

Unrelated and unneeded, please remove the 'if', g_free is NULL safe.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list