[Bug 733187] integrating the tracer branch
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Wed Jan 6 11:50:08 PST 2016
https://bugzilla.gnome.org/show_bug.cgi?id=733187
--- Comment #36 from Stefan Sauer (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> ---
(In reply to Tim-Philipp Müller from comment #34)
> - gst_tracer_log_trace() is not annotated/documented. Is it supposed to be
> *the* standard function by which tracers communicate results back, or just
> something simple for now that always dumps the data into the debug log?
>
> - does gst_tracing_register_hook_id() make sense as public API?
> - it's not performance-critical, so just passing strings is fine
> - quark table is not exported (good thing too really?)
> - hook id quarks are run-time generated and basically random instead of
> constant, so an enum might be better if one really wants something like this
> (like the old GstTracerHookId which was removed again)
> - tracer hooks are looked up in a hash table anyway, might just as well
> use the strings directly as key then if we don't have an array or such
commit 5e40639be7a3b8b809d216d49a79012dbf1dc37d
Author: Stefan Sauer <ensonic at users.sf.net>
Date: Wed Jan 6 20:41:26 2016 +0100
tracer: make gst_tracing_register_hook_id static
We don't need to expose this as public API. Change the only plugin that was
using it.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list