[Bug 760239] [PATCH] matroska demux : capture tag from sink event and merge it to global tags
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Wed Jan 6 14:27:05 PST 2016
https://bugzilla.gnome.org/show_bug.cgi?id=760239
Sebastian Dröge (slomo) <slomo at coaxion.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #318384|none |needs-work
status| |
--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 318384:
--> (https://bugzilla.gnome.org/review?bug=760239&attachment=318384)
::: gst/matroska/matroska-demux.c
@@ +4840,3 @@
+ gst_event_parse_tag (event, &new_list);
+ gst_matroska_read_common_found_global_tag (&demux->common,
+ GST_ELEMENT_CAST (demux), new_list);
After this gst_matroska_demux_send_tags() needs to be called at some point.
Maybe should be called before every gst_pad_push()?
In your case it probably works without because your tags arrive before the
header of the Matroska file is parsed, and during header parsing that function
is called anyway.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list