[Bug 760239] matroskademux : capture tag from sink event and merge it to global tags

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=760239

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #318391|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 318391:
 --> (https://bugzilla.gnome.org/review?bug=760239&attachment=318391)

::: gst/matroska/matroska-demux.c
@@ +4841,3 @@
+      gst_matroska_read_common_found_global_tag (&demux->common,
+          GST_ELEMENT_CAST (demux), new_list);
+      gst_matroska_demux_send_tags (demux);

I don't think that works as is... you don't necessarily have any source pads at
this point. That's why I said it should probably happen before pushing
buffers... but maybe *also* before pushing buffers and having it here.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.