[Bug 758232] Add support for EBU-TT-D / TTML subtitles

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=758232

--- Comment #9 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Chris Bass from comment #8)
> (In reply to Sebastian Dröge (slomo) from comment #7)
> [...]
> > 
> > Why the LEGAL file in addition to what is written inside the files?
> 
> When I went through my employer's Open Source release process, our legal
> team wanted this wording included somewhere (separate from the LGPL text).
> 
> I noticed that qtdemux had a LEGAL file in its directory in plugins-good, so
> I copied that approach. Is this problematic?

Not really problematic, it just usually causes more confusion than it solves
compared to just having this information at the top of the relevant files :)

> > Also why are you including all the other stuff from subparse, e.g. the
> > tmplayerparse.c and samiparse.c
> 
> With the TTML parser, it was amenable to creating a patch to add it to
> subparse, so I tried to avoid changing the subparse bits too much. (The
> renderer is a pretty big departure from basetextoverlay - big enough that it
> couldn't really be added by a patch - so I didn't attempt to keep the other
> bits of the pango plugin).
> 
> Do you want me to strip out the non-TTML bits from the parser?

Is the functionality exposed by the plugin and does it do something different
than in subparse? I.e. is it also supporting the same intermediate subtitle
format as used for TTML for all the other formats nowadays supported by
subparse?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.